[PATCH] D13439: DAGCombiner: Don't stop finding better chain on 2 aliases

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 5 09:31:56 PDT 2015


arsenm added inline comments.

================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:14365
@@ -14366,3 +14364,3 @@
     // chain.
-    if (Depth > 6 || Aliases.size() == 2) {
+    if (Depth > 6) {
       Aliases.clear();
----------------
hfinkel wrote:
> It would be nice, IMHO, to get rid of these hard-coded depth limits and turn them into cl::opts. This is a general comment, as I feel the same way about all of these depth limits everywhere. [I'm not requesting that you change this here].
I have a later patch that turns this into a TargetLowering preference. The depth limit is a problem if you want to find adjacent large vectors 


http://reviews.llvm.org/D13439





More information about the llvm-commits mailing list