[PATCH] D13392: [ELF2] - Implemented --exclude-libs flag

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 5 08:52:05 PDT 2015


On Mon, Oct 5, 2015 at 3:05 AM, George Rimar <grimar at accesssoftek.com>
wrote:

> grimar added a comment.
>
> In http://reviews.llvm.org/D13392#258851, @ruiu wrote:
>
> > I'm still reviewing this change, but I guess my question I have now is
> how important this feature is. Do you need this now, or is this high
> priority? New ELF LLD is still very early, and all code is likely to be
> refactored or modified, so I wouldn't want to add that much amount of code
> unless a feature is implemented pretty easily or important.
>
>
> Not sure how this feature is important and I definitely dont need it right
> now.
> I just thought it could be useful. At least from design side, before this
> patch there was no possibility to determine to which archive currently
> parced file belongs to.
> Further modifications and refactorings at least should take care of that.
> All other changes performed seems minor and/or local for that flag to me.
> Just in case I updated the diff to address all comments and be in touch
> with latest revision.
> But If you think its too early fot that - please let me know and I will
> abandon the diff.
>

I appreciate this change, but this particular feature is probably too much
for the current infant LLD. I'd implement that once it's complete for
regular day-to-day use. Let's postpone until that day.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151005/1827dfd7/attachment.html>


More information about the llvm-commits mailing list