[PATCH] D13413: Use MSVC-equivalents of attributes

David Majnemer via llvm-commits llvm-commits at lists.llvm.org
Sun Oct 4 11:49:19 PDT 2015


majnemer added a subscriber: majnemer.

================
Comment at: lib/builtins/int_util.h:22-28
@@ -21,1 +21,9 @@
 
+#ifdef _MSC_VER
+#define __NORETURN(x) __declspec(noreturn) x
+#define __UNUSED
+#else
+#define __NORETURN(x) x __attribute__((noreturn))
+#define __UNUSED __attribute__((unused))
+#endif
+
----------------
Why are these macros underscore prefixed?  I don't think we should invade the implementor's namespace here.


http://reviews.llvm.org/D13413





More information about the llvm-commits mailing list