[polly] r249267 - Use AssertingVH for ValueToValue Maps

Tobias Grosser via llvm-commits llvm-commits at lists.llvm.org
Sun Oct 4 03:18:50 PDT 2015


Author: grosser
Date: Sun Oct  4 05:18:49 2015
New Revision: 249267

URL: http://llvm.org/viewvc/llvm-project?rev=249267&view=rev
Log:
Use AssertingVH for ValueToValue Maps

By using AssertingVH we will see assertions in case Values to which still
pointers in our maps exists are deleted. This is very useful as we previously
had some bugs that were caused by such stale Value pointers.

Modified:
    polly/trunk/include/polly/CodeGen/BlockGenerators.h

Modified: polly/trunk/include/polly/CodeGen/BlockGenerators.h
URL: http://llvm.org/viewvc/llvm-project/polly/trunk/include/polly/CodeGen/BlockGenerators.h?rev=249267&r1=249266&r2=249267&view=diff
==============================================================================
--- polly/trunk/include/polly/CodeGen/BlockGenerators.h (original)
+++ polly/trunk/include/polly/CodeGen/BlockGenerators.h Sun Oct  4 05:18:49 2015
@@ -67,7 +67,8 @@ public:
   /// @see The ScalarMap and PHIOpMap member.
   using ScalarAllocaMapTy = DenseMap<AssertingVH<Value>, AssertingVH<Value>>;
 
-  typedef llvm::DenseMap<llvm::Value *, llvm::Value *> ValueMapT;
+  typedef llvm::DenseMap<AssertingVH<llvm::Value>, AssertingVH<llvm::Value>>
+      ValueMapT;
   typedef llvm::SmallVector<ValueMapT, 8> VectorValueMapT;
 
   /// @brief Simple vector of instructions to store escape users.




More information about the llvm-commits mailing list