[PATCH] D13378: [SCEV] Recognize simple br-phi patterns

Sanjoy Das via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 2 14:02:49 PDT 2015


sanjoy added a comment.

In http://reviews.llvm.org/D13378#258915, @joker.eph wrote:

> Hi Sanjoyd,
>
> Thanks for the clarification on the Constant Select, isn't it something that could be handled as well? Especially with http://reviews.llvm.org/D13390 coming?


I'm not sure there is much value in optimizing `ConstantExpr`s in SCEV, because they're compile time constants anyway (though they may need to remain symbolic till link time).  I'd just wait till we see a case where it matters in practice.

> See inline some other comments.

> 

> Thanks!





http://reviews.llvm.org/D13378





More information about the llvm-commits mailing list