[PATCH] D13347: [FastISel][X86] Teach how to select SSE2/AVX bitcasts between 128/256-bit vector types.

[Quentin Colombet via llvm-commits]

qcolombet added inline comments.

================
Comment at: lib/Target/X86/X86FastISel.cpp:3247
@@ +3246,3 @@
+        SrcVT.getSizeInBits() != DstVT.getSizeInBits())
+      return false;
+
----------------
andreadb wrote:
> qcolombet wrote:
> > Could you add test cases for these checks?
> > In particular the different SizeInBits part.
> My bad.. That check makes no sense since source and destination bit widths must always be identical for bitcast operations.
> I will remove that redundant check.
Hehe, thanks for checking, I was wondering if the data layout may break that assumption and if it does, when!


http://reviews.llvm.org/D13347