[PATCH] D13274: [WinEH] Clone funclets with multiple parents

Joseph Tremoulet via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 1 14:04:09 PDT 2015


JosephTremoulet added inline comments.

================
Comment at: lib/CodeGen/WinEHPrepare.cpp:2978
@@ -2969,2 +2977,3 @@
   for (BasicBlock *FuncletEntry : EntryBlocks) {
     std::set<BasicBlock *> &ColorMapItem = BlockColors[FuncletEntry];
+    for (BasicBlock *Parent : ColorMapItem) {
----------------
Since we expect multi-parent funclets to be extremely rare, it's probably worthwhile to record here whether you ever see a `ColorMapItem` with size > 1, then have `resolveFuncletAncestry(Function*)` check that and return immediately if there's no work for it to do.


Repository:
  rL LLVM

http://reviews.llvm.org/D13274





More information about the llvm-commits mailing list