[PATCH] D13355: [ELF2] --no-undefined flag implemented

[Rui Ueyama via llvm-commits]

ruiu added inline comments.

================
Comment at: ELF/Options.td:41
@@ +40,3 @@
+    : Flag<["--"], "no-undefined">,
+      HelpText<"Report unresolved symbol references from regular object files "
+               "even if the linker is creating a non-symbolic shared library.">;
----------------
grimar wrote:
> ruiu wrote:
> > ruiu wrote:
> > > Indentation error.
> > Let's make the message a bit shorter: "Report unresolved symbols even if the linker is creating a shared library"
> > 
> > Do not put period at end as other messages don't.
> Thats how clang-format handles it i believe. But after your comments I understood that  it is not supposed to be used in this file :)
Is it? I've never tried to apply clang-format to .td files, but if that's the case, we may want to follow the style how clang-format does. But even if we want to do, that should be done at once. Please always keep everything as consistent as possible.


http://reviews.llvm.org/D13355