[PATCH] D13244: [ELF2] - implemented --allow-shlib-undefined/--no-allow-shlib-undefined

[Rui Ueyama via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM

Please update the commit message.

[ELF2] Implement --allow-shlib-undefined as default behavior.

We ignore --{no,}allow-shlib-undefined options and always allow undefined
symbols if we are building a DSO.


================
Comment at: ELF/Options.td:65-69
@@ +64,6 @@
+
+def no_allow_shlib_undefined
+    : Flag<["--"], "no-allow-shlib-undefined">;
+
+def allow_shlib_undefined
+    : Flag<["--"], "allow-shlib-undefined">;
----------------
Write each of them in one line and move at the end of the file below "these flags are ignored ..." fold after rebasing.

================
Comment at: ELF/Writer.cpp:274-275
@@ -273,1 +273,4 @@
 
+  if (Config->Shared)
+    return;
+
----------------
My concern was it returns without doing anything although the name implies it's fatal. But I renamed this function, so it should be fine now.


http://reviews.llvm.org/D13244