[PATCH] D13151: Expand loop reroll to handle loop with multiple induction variables and negative increment -part 2/3

[Lawrence Hu via llvm-commits]

hulx2000 marked 16 inline comments as done.
hulx2000 added a comment.

Thanks, James, most of your concerns are addressed


================
Comment at: lib/Transforms/Scalar/LoopRerollPass.cpp:1361
@@ +1360,3 @@
+  const SCEVAddRecExpr *AddRecExpr = nullptr;
+  const SCEV *SizeOfExpr = nullptr;
+  const SCEV *IncrExpr =
----------------
jmolloy wrote:
> I don't like that these are declared outside of scope and initialized to nullptr - this isn't C, we can declare variables where we use them! :) Please sink these into the if expression (you can just use auto too)
SizeOfExpr is used later, can't be declared in side if statement


Repository:
  rL LLVM

http://reviews.llvm.org/D13151