[PATCH] D13314: Enable -Wdeprecated in the cmake build now that LLVM (& Clang, Polly, and LLD) are -Wdeprecated clean

Aaron Ballman via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 30 16:16:30 PDT 2015


On Wed, Sep 30, 2015 at 7:07 PM, David Blaikie via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> dblaikie created this revision.
> dblaikie added a reviewer: chandlerc.
> dblaikie added a subscriber: llvm-commits.
>
> This particularly helps enforce the C++ Rule of 5 (for new move ops this
> is already an error, but for a type only using C++98 features (copy
> ctor/assign, dtor) it is only deprecated, not invalid)
>
> http://reviews.llvm.org/D13314
>
> Files:
>   cmake/modules/HandleLLVMOptions.cmake
>
> Index: cmake/modules/HandleLLVMOptions.cmake
> ===================================================================
> --- cmake/modules/HandleLLVMOptions.cmake
> +++ cmake/modules/HandleLLVMOptions.cmake
> @@ -364,7 +364,7 @@
>
>  elseif( LLVM_COMPILER_IS_GCC_COMPATIBLE )
>    if (LLVM_ENABLE_WARNINGS)
> -    append("-Wall -W -Wno-unused-parameter -Wwrite-strings" CMAKE_C_FLAGS CMAKE_CXX_FLAGS)
> +    append("-Wall -W -Wno-unused-parameter -Wwrite-strings -Wdeprecated" CMAKE_C_FLAGS CMAKE_CXX_FLAGS)
>      append("-Wcast-qual" CMAKE_CXX_FLAGS)
>
>      # Turn off missing field initializer warnings for gcc to avoid noise from

LGTM! Thank you for working on this!

~Aaron

>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>


More information about the llvm-commits mailing list