[PATCH] D13301: [SimplifyLibCalls] Fix instruction misplacement in string/memory libcall optimization

[Ahmed Bougacha via llvm-commits]

ab accepted this revision.
ab added a comment.
This revision is now accepted and ready to land.

Seems reasonable, thanks!


================
Comment at: lib/Transforms/Utils/SimplifyLibCalls.cpp:2080
@@ -2078,1 +2079,3 @@
+    // to guarantee we reach all uses we might replace later on.
+    IRBuilder<> TmpBuilder(SimplifiedCI ? SimplifiedCI : CI);
     if (SimplifiedCI && SimplifiedCI->getCalledFunction())
----------------
Why not sink this in the block below? That'll eliminate the need for the SimplifiedCI null check.


Repository:
  rL LLVM

http://reviews.llvm.org/D13301