[PATCH] D13244: [ELF2] - implemented --allow-shlib-undefined/--no-allow-shlib-undefined

[Rui Ueyama via llvm-commits]

ruiu added inline comments.

================
Comment at: ELF/Options.td:65-71
@@ +64,8 @@
+
+def no_allow_shlib_undefined
+    : Flag<["--"], "no-allow-shlib-undefined">,
+      HelpText<"This flag is ignored. --allow-shlib-undefined is always set">;
+
+def allow_shlib_undefined
+    : Flag<["--"], "allow-shlib-undefined">,
+      HelpText<"This flag is ignored. --allow-shlib-undefined is always set">;
----------------
We don't need help texts for these no-op flags.

================
Comment at: ELF/Writer.cpp:174
@@ -173,1 +173,3 @@
 
+void undefError(const Twine &Symbol, const Twine &SymFile) {
+  // DSO can contain unresolved symbols
----------------
Export this function when you need it. Currently no one is using this except undefError().

Also please avoid overriding function unless it really makes sense. We already have this function,

  template <class ELFT> static void undefError(const SymbolTable &, const SymbolBody &);
 
and this patch defines

  void undefError(const Twine &, const Twine &)

That's confusing. You can just give different names.


http://reviews.llvm.org/D13244