[PATCH] D13215: [CMake] Make the bindir and libdir arguments to set_output_directory optional

[John Brawn via llvm-commits]

john.brawn added inline comments.

================
Comment at: cmake/modules/AddLLVM.cmake:206
@@ -197,1 +205,3 @@
+  set(bindir ${ARGV1})
+  set(libdir ${ARGV2})
   # Do nothing if *_OUTPUT_INTDIR is empty.
----------------
beanz wrote:
> I think that a better way to do this would be to use `cmake_parse_arguments` and make output and bind directory be single value options. Then if one isn't specified it is ignored.
> 
> I also think it would be cleaner if set_target_properties were only called if the corresponding value is set.
I had thought of using cmake_parse_arguments, but decided against it as it would involve changing how set_output_directory is called. It's only called in three places though, so actually that won't be too much trouble. I'll give it a go.


Repository:
  rL LLVM

http://reviews.llvm.org/D13215