[PATCH] D13227: [ELF2] Add initial MIPS support

Simon Atanasyan via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 28 15:15:58 PDT 2015


atanasyan marked 3 inline comments as done.

================
Comment at: ELF/SymbolTable.cpp:50-51
@@ -49,2 +49,4 @@
     return new ARMTargetInfo();
+  case EM_MIPS:
+    return new MipsTargetInfo();
   case EM_PPC:
----------------
ruiu wrote:
> These cases need to be sorted by ASCIIbetical order, but yeah, that should be done in a different patch.
The case labels are sorted already. Do you want to sort them by xxxTargetInfo class names?

================
Comment at: test/elf2/basic-mips.s:5
@@ +4,3 @@
+# RUN:   | FileCheck %s
+
+# REQUIRES: mips
----------------
davide wrote:
> Extra \n
I think it is better to separate "running" instructions (RUN) from "configuration" instructions (REQUIRES).


Repository:
  rL LLVM

http://reviews.llvm.org/D13227





More information about the llvm-commits mailing list