[PATCH] D13227: [ELF2] Add initial MIPS support

[Rui Ueyama via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM with a nit.


================
Comment at: ELF/SymbolTable.cpp:50-51
@@ -49,2 +49,4 @@
     return new ARMTargetInfo();
+  case EM_MIPS:
+    return new MipsTargetInfo();
   case EM_PPC:
----------------
These cases need to be sorted by ASCIIbetical order, but yeah, that should be done in a different patch.

================
Comment at: ELF/Target.h:38
@@ -34,2 +37,3 @@
   unsigned GotReloc;
+  llvm::StringRef DefEntryName = "_start";
 };
----------------
It's probably a matter of taste, but I'd name DefaultEntry instead of DefEntryName. (Because the linker mainly handles names, "name" tend to be added everywhere, so I wouldn't add that in the first place.)


Repository:
  rL LLVM

http://reviews.llvm.org/D13227