[PATCH] D12704: [ASan] Don't instrument promotable dynamic allocas.

Maxim Ostapenko via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 28 07:42:01 PDT 2015


m.ostepenko accepted this revision.
m.ostepenko added a comment.
This revision is now accepted and ready to land.

Ah, right, I see that we indeed can mess with dynamic allocas and lifetime intrinsics here (in such cases, when alloca's size is known in compile time, but it's treated as dynamic one for others reasons).

Alexey, could you please land this?

Thanks!


================
Comment at: lib/Transforms/Instrumentation/AddressSanitizer.cpp:433
@@ -432,3 +432,3 @@
   bool isDynamicAlloca(AllocaInst &AI) const {
     return AI.isArrayAllocation() || !AI.isStaticAlloca();
   }
----------------
I wonder if we should remove isArrayAllocation() from this filter.


http://reviews.llvm.org/D12704





More information about the llvm-commits mailing list