[PATCH] D13212: [ELF2] - Implemented -e flag

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 28 07:06:27 PDT 2015


ruiu added inline comments.

================
Comment at: ELF/Driver.cpp:100
@@ -99,1 +99,3 @@
 
+  // Handle -e
+  if (auto *Arg = Args.getLastArg(OPT_e))
----------------
grimar wrote:
> ruiu wrote:
> > We don't have comments for other options above.
> I`ll remove if you wish. Other are self-explaining, I thought at least reference to "-e" makes it more clear.
This is also self-explanatory since the name of the variable is OPT_e (thus this is for -e). Can you add both --entry and -e to Options.td and use OPT_entry instead?


http://reviews.llvm.org/D13212





More information about the llvm-commits mailing list