[PATCH] D13012: [X86] Add XSAVE intrinsics (LLVM part)

Craig Topper via llvm-commits llvm-commits at lists.llvm.org
Sun Sep 27 09:18:52 PDT 2015


craig.topper added inline comments.

================
Comment at: lib/Support/Host.cpp:830
@@ +829,3 @@
+  Features["xsavec"]   = Features["xsave"] && HasLeafd && ((ECX >> 1) & 1);
+  Features["xg1"]      = Features["xsave"] && HasLeafd && ((ECX >> 2) & 1);
+  Features["xsaves"]   = Features["xsave"] && HasLeafd && ((ECX >> 3) & 1);
----------------
Is this needed? Bit 2 doesn't correspond to any instructions. It determines whether xgetbv allows ecx=1


Repository:
  rL LLVM

http://reviews.llvm.org/D13012





More information about the llvm-commits mailing list