[PATCH] D13164: [LNT] Fix postgres unit tests by closing db connections.

Kristof Beyls via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 25 07:59:25 PDT 2015


kristof.beyls created this revision.
kristof.beyls added reviewers: cmatthews, ddunbar.
kristof.beyls added a subscriber: llvm-commits.

When running the unit tests on a postgres database, the following error shows:

sqlalchemy.exc.TimeoutError: QueuePool limit of size 5 overflow 10 reached, connection timed out, timeout 30

We've also seen this error from time to time on the instance running at
llvm.org/perf, and it was unclear what the exact reason was for this.  Now that
we can run the unit tests on postgres, this shows that not closing the db
connection at the end of a request is at least one of the reasons this error
can be produced.

This builds on http://reviews.llvm.org/D13163, which makes it possible to run the unit tests on postgres instead of sqlite.

http://reviews.llvm.org/D13164

Files:
  lnt/lnttool/import_data.py
  lnt/lnttool/main.py
  lnt/lnttool/updatedb.py
  lnt/lnttool/viewcomparison.py
  lnt/server/db/v4db.py
  lnt/server/ui/app.py
  lnt/util/ImportData.py
  lnt/util/ServerUtil.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D13164.35724.patch
Type: text/x-patch
Size: 19101 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150925/dc95b0f1/attachment.bin>


More information about the llvm-commits mailing list