[PATCH] D8815: [RuntimeDyld] Initial limited TLS support

Jameson Nash via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 24 22:39:50 PDT 2015


vtjnash added a subscriber: vtjnash.

================
Comment at: lib/ExecutionEngine/RuntimeDyld/TLSSymbolResolverELF.cpp:49
@@ +48,3 @@
+    RuntimeDyld::SymbolInfo SI = SR->findSymbol(Name);
+    uint64_t Value = SI.getAddress();
+
----------------
this Value is only correct if MemoryManager hasn't cached the address from a different thread. Since the function is using `pthread_self` for direct interaction with the host system anyways, maybe it should just call `dlsym` also?


Repository:
  rL LLVM

http://reviews.llvm.org/D8815





More information about the llvm-commits mailing list