[PATCH] D13153: [ELF2] Use static non-member function when it suffices

Shankar Easwaran via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 24 20:55:26 PDT 2015


shankare added a subscriber: shankare.

================
Comment at: ELF/Writer.cpp:339-340
@@ -338,4 +338,4 @@
         ErrorOr<StringRef> SymName = Sym.getName(File.getStringTable());
-        if (SymName && SymTabSec.shouldKeepInSymtab(*SymName))
+        if (SymName && shouldKeepInSymtab(*SymName))
           SymTabSec.addSymbol(*SymName, true);
       }
----------------
what if discard all and discard none is used ? Do we plan to print any warning of what option was chosen ?


Repository:
  rL LLVM

http://reviews.llvm.org/D13153





More information about the llvm-commits mailing list