[llvm] r248534 - Use ELFOSABI_NONE instead of ELFOSABI_LINUX.

Rafael Espindola via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 24 13:57:25 PDT 2015


Author: rafael
Date: Thu Sep 24 15:57:24 2015
New Revision: 248534

URL: http://llvm.org/viewvc/llvm-project?rev=248534&view=rev
Log:
Use ELFOSABI_NONE instead of ELFOSABI_LINUX.

The doesn't seem to be a difference and ELFOSABI_NONE seems to be far more
common:

* Linux doesn't care when loading and puts ELFOSABI_NONE on core dumps.
* Gold and bfd ld produce files with ELFOSABI_NONE.
* Gold and bfd ld seems to ignore EI_OSABI other than for freebsd.
* Gas puts ELFOSABI_NONE in most .o files.

Modified:
    llvm/trunk/include/llvm/MC/MCELFObjectWriter.h
    llvm/trunk/test/MC/AArch64/elf_osabi_flags.s
    llvm/trunk/test/MC/Mips/elf_basic.s

Modified: llvm/trunk/include/llvm/MC/MCELFObjectWriter.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/MC/MCELFObjectWriter.h?rev=248534&r1=248533&r2=248534&view=diff
==============================================================================
--- llvm/trunk/include/llvm/MC/MCELFObjectWriter.h (original)
+++ llvm/trunk/include/llvm/MC/MCELFObjectWriter.h Thu Sep 24 15:57:24 2015
@@ -57,8 +57,6 @@ public:
       case Triple::PS4:
       case Triple::FreeBSD:
         return ELF::ELFOSABI_FREEBSD;
-      case Triple::Linux:
-        return ELF::ELFOSABI_LINUX;
       default:
         return ELF::ELFOSABI_NONE;
     }

Modified: llvm/trunk/test/MC/AArch64/elf_osabi_flags.s
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/AArch64/elf_osabi_flags.s?rev=248534&r1=248533&r2=248534&view=diff
==============================================================================
--- llvm/trunk/test/MC/AArch64/elf_osabi_flags.s (original)
+++ llvm/trunk/test/MC/AArch64/elf_osabi_flags.s Thu Sep 24 15:57:24 2015
@@ -1,5 +1,4 @@
-# RUN: llvm-mc -filetype=obj -triple aarch64 %s -o -| llvm-readobj -h | FileCheck --check-prefix=AARCH64-OSABI %s
-# AARCH64-OSABI: OS/ABI: SystemV (0x0)
+# RUN: llvm-mc -filetype=obj -triple aarch64 %s -o -| llvm-readobj -h | FileCheck %s
+# RUN: llvm-mc -filetype=obj -triple aarch64-linux-gnu %s -o -| llvm-readobj -h | FileCheck %s
 
-# RUN: llvm-mc -filetype=obj -triple aarch64-linux-gnu %s -o -| llvm-readobj -h | FileCheck --check-prefix=AARCH64-LINUX-OSABI %s
-# AARCH64-LINUX-OSABI: OS/ABI: GNU/Linux (0x3)
+# CHECK: OS/ABI: SystemV (0x0)

Modified: llvm/trunk/test/MC/Mips/elf_basic.s
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/Mips/elf_basic.s?rev=248534&r1=248533&r2=248534&view=diff
==============================================================================
--- llvm/trunk/test/MC/Mips/elf_basic.s (original)
+++ llvm/trunk/test/MC/Mips/elf_basic.s Thu Sep 24 15:57:24 2015
@@ -36,6 +36,6 @@
 // CHECK-LE64:   Ident {
 // CHECK-LE64:     Class: 64-bit
 // CHECK-LE64:     DataEncoding: LittleEndian
-// CHECK-LE64:     OS/ABI: GNU/Linux
+// CHECK-LE64:     OS/ABI: SystemV
 // CHECK-LE64:   }
 // CHECK-LE64: }




More information about the llvm-commits mailing list