[PATCH] D12055: AMDGPU: Add cache invalidation instructions.

Tom Stellard via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 24 06:24:51 PDT 2015


tstellarAMD accepted this revision.
tstellarAMD added a comment.
This revision is now accepted and ready to land.

Just one small change request, with that fixed, LGTM.


================
Comment at: test/MC/AMDGPU/mubuf.s:370
@@ +369,3 @@
+// CI: buffer_wbinvl1_vol ; encoding: [0x00,0x00,0xc0,0xe1,0x00,0x00,0x00,0x00]
+// XVI: buffer_wbinvl1_vol ; encoding: [0x00,0x00,0xfc,0xe0,0x00,0x00,0x00,0x00]
+// NOSI: error: instruction not supported on this GPU
----------------
Could you move the XVI: line into its own file and XFAIL it.  I think this will make it easier to track.



http://reviews.llvm.org/D12055





More information about the llvm-commits mailing list