[PATCH] D13023: [Bug 21683 relative] - Refactor of SimpleDefinedAtom::sortReferences()

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 23 14:33:43 PDT 2015


On Wed, Sep 23, 2015 at 12:37 PM, Lang Hames <lhames at gmail.com> wrote:

> lhames added a subscriber: lhames.
> lhames added a comment.
>
> I would expect the cost of a linked-list sort to quickly exceed the cost
> of copying to/from the vector and sorting there. If that's the case this
> tidy-up may not be worth the performance hit?
>

That's good point and I'd agree. Vectors could be much faster than sorting
a linked list in place because of its better locality.


>
> http://reviews.llvm.org/D13023
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150923/4a0ef9bc/attachment.html>


More information about the llvm-commits mailing list