[PATCH] D13059: [CMake] [Darwin] Bug 21562 - Add a CMake equivalent for make/platform/clang_darwin.mk in compiler_rt

Alexey Samsonov via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 22 13:49:31 PDT 2015


samsonov added inline comments.

================
Comment at: cmake/Modules/CompilerRTDarwinUtils.cmake:137
@@ +136,3 @@
+    ${ARGN})
+  set(libname "${name}_${LIB_ARCH}_${LIB_OS}")
+  add_library(${libname} STATIC ${LIB_SOURCES})
----------------
beanz wrote:
> The required customization to make `add_compiler_rt_runtime` work seemed a bit much. For example we don't actually want to install the library generated here because it should be lipo'd together per-os.
OK, makes sense.


http://reviews.llvm.org/D13059





More information about the llvm-commits mailing list