[PATCH] D13050: [ELF2] Fix an assertion failure on 32-bit platform

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 22 08:23:37 PDT 2015


On 22 September 2015 at 08:36, Igor Kudrin <ikudrin.dev at gmail.com> wrote:
> ikudrin added a comment.
>
> It fails on Windows (target triple i686-pc-win32) with MSVC 14.

I was able to reproduce this too with MSVC 13.

There is something odd going on. The overflow of unsigned numbers has
defined semantics. Looks like MSVC is just getting confused with the
isInt template.

In any case, all that you need to do to fix the test with MSVC is
change the type of Delta. LGTM with that.

Cheers,
Rafael


More information about the llvm-commits mailing list