[PATCH] D12189: [mips][sched] Split IIBranch into specific instruction classes.

Daniel Sanders via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 22 05:44:35 PDT 2015


dsanders added inline comments.

================
Comment at: lib/Target/Mips/MicroMipsInstrInfo.td:167-169
@@ -166,5 +166,5 @@
 class CompactBranchMM<string opstr, DAGOperand opnd, PatFrag cond_op,
-                      RegisterOperand RO> :
+                      RegisterOperand RO, InstrItinClass itin = NoItinerary> :
   InstSE<(outs), (ins RO:$rs, opnd:$offset),
-         !strconcat(opstr, "\t$rs, $offset"), [], IIBranch, FrmI> {
+         !strconcat(opstr, "\t$rs, $offset"), [], II_BCCZC, FrmI> {
   let isBranch = 1;
----------------
vkalintiris wrote:
> We can use `II_BCCZC` for the time being as the default value for `itin`. We don't override this value anywhere as far as I can tell.
It seems we don't use itin anywhere so I'll just remove the argument.


http://reviews.llvm.org/D12189





More information about the llvm-commits mailing list