[PATCH] D12698: DAGCombiner: Replace store of FP constant after attemping store merges

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 21 08:41:07 PDT 2015


arsenm added inline comments.

================
Comment at: test/CodeGen/PowerPC/vector-merge-store-fp-constants.ll:1
@@ +1,2 @@
+; RUN: llc -march=ppc64 -mtriple=ppc64-apple-darwin -mattr=+altivec < %s | FileCheck %s
+
----------------
spatel wrote:
> We shouldn't need -mattr=altivec or darwin here; that was excess in the bug report.
> Also, for this test and the next one: if you specify the triple, does it change anything to also specify the arch?
I don't think it does anything, but I usually specify both


http://reviews.llvm.org/D12698





More information about the llvm-commits mailing list