[PATCH] D13003: [DAGCombiner] Improve FMA support for interpolation patterns

Simon Pilgrim via llvm-commits llvm-commits at lists.llvm.org
Sun Sep 20 12:00:50 PDT 2015


RKSimon added a comment.

> There aren't any tests stressing the FMAD path. AMDGPU seems to be only target using it still, and the one test change is in the expansion of an intrinsic which should be removed. If you can add some of those that would be good, otherwise I can try to do it after you commit


Thanks Matt, I can add some FMAD tests for v_mad_f32 - is that the only instruction I should be testing for?

Most of your comments about the preamble are just as relevant for the other FMA pattern combines (visitFADDForFMACombine, visitFSUBForFMACombine); given that I copied+pasted most of it from them should they be updated as well?


Repository:
  rL LLVM

http://reviews.llvm.org/D13003





More information about the llvm-commits mailing list