[PATCH] D12593: AVX512 : vcmpss/sd implementation

[Elena Demikhovsky via llvm-commits]

delena added inline comments.

================
Comment at: lib/Target/X86/X86ISelLowering.cpp:15764
@@ -15763,1 +15763,3 @@
 
+    switch (Op.getOpcode()) {
+      default: break;
----------------
Please use "if" here.

================
Comment at: lib/Target/X86/X86ISelLowering.cpp:16156
@@ +16155,3 @@
+      return DAG.getNode(ISD::SIGN_EXTEND_INREG, dl, MVT::i8,
+                         DAG.getNode(ISD::ZERO_EXTEND, dl, MVT::i8, CmpMask),
+                         DAG.getValueType(MVT::i1));
----------------
ZERO_EXTEND -> ANY_EXTEND


Repository:
  rL LLVM

http://reviews.llvm.org/D12593