[PATCH] D9638: Implement `internal_start/join_thread` on Mac OS X

Kostya Serebryany via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 18 15:04:50 PDT 2015


kcc added a comment.

I am ok with the change. 
AFIACT, it does not add any new functionality as is but is required for other changes, right? 
I wonder, is it possible to add a test for this?


================
Comment at: lib/sanitizer_common/sanitizer_mac.cc:368
@@ -367,3 +367,3 @@
 
-void *internal_start_thread(void (*func)(void *arg), void *arg) { return 0; }
-void internal_join_thread(void *th) { }
+// FIXME: Move internal_start_thread and internal_join_thread from both Mac and
+// Linux into sanitizer_posix.cc.
----------------
I am not convinced we need to move this to a common place. You may drop this TODO. 


http://reviews.llvm.org/D9638





More information about the llvm-commits mailing list