[llvm] r247980 - [Support] Reapply r245289 "Always wait for GraphViz before opening the viewer"

[Michael Kruse via llvm-commits]

Author: meinersbur
Date: Fri Sep 18 05:56:30 2015
New Revision: 247980

URL: http://llvm.org/viewvc/llvm-project?rev=247980&view=rev
Log:
[Support] Reapply r245289 "Always wait for GraphViz before opening the viewer"

The change was accidentally undone by r245290.

Original log message:
When calling DisplayGraph and a PS viewer is chosen, two programs are executed: The GraphViz generator and the PostScript viewer. Always wait for the generator to finish to ensure that the .ps file is written before opening the viewer for that file. DisplayGraph's wait parameter refers to whether to wait until the user closes the viewer.

This happened on Windows and if none of the options to open the .dot file directly applies, also on Linux.

Differential Revision: http://reviews.llvm.org/D11876

Modified:
    llvm/trunk/lib/Support/GraphWriter.cpp

Modified: llvm/trunk/lib/Support/GraphWriter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/GraphWriter.cpp?rev=247980&r1=247979&r2=247980&view=diff
==============================================================================
--- llvm/trunk/lib/Support/GraphWriter.cpp (original)
+++ llvm/trunk/lib/Support/GraphWriter.cpp Fri Sep 18 05:56:30 2015
@@ -234,7 +234,7 @@ bool llvm::DisplayGraph(StringRef Filena
 
     errs() << "Running '" << GeneratorPath << "' program... ";
 
-    if (ExecGraphViewer(GeneratorPath, args, Filename, wait, ErrMsg))
+    if (ExecGraphViewer(GeneratorPath, args, Filename, true, ErrMsg))
       return true;
 
     // The lifetime of StartArg must include the call of ExecGraphViewer