[PATCH] D12887: [Machine Combiner] Refactor machine reassociation into a target-independent pass

Gerolf Hoflehner via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 16 10:19:26 PDT 2015


+1
> On Sep 15, 2015, at 1:28 PM, Sanjay Patel <spatel at rotateright.com> wrote:
> 
> spatel added a reviewer: Gerolf.
> spatel added a comment.
> 
> I support refactoring the reassociation code to be target-independent, but I'm wondering: what is the benefit from making this a separate pass from MachineCombiner?
> 
> If I'm seeing it correctly, this patch has exactly duplicated a few hundred lines of code for MachineReassociation::reassociateInstructions() and its helpers from the existing pass.
> 
> 
> Repository:
>  rL LLVM
> 
> http://reviews.llvm.org/D12887
> 
> 
> 



More information about the llvm-commits mailing list