[PATCH] D12853: Introduce !value.align metadata for load instruction

[Sanjoy Das via llvm-commits]

sanjoy added inline comments.

================
Comment at: docs/LangRef.rst:6856
@@ -6854,1 +6855,3 @@
 
+The optional ``!value.align`` metadata must reference a single
+metadata name ``<value_align_node>`` corresponding to a metadata node with one
----------------
Is it restricted to be a power of two (I'd guess so)?  If so, that should be noted here.

================
Comment at: lib/Analysis/ValueTracking.cpp:2962
@@ -2956,3 +2961,3 @@
   if (!BaseAlign) {
     Type *Ty = Base->getType()->getPointerElementType();
     BaseAlign = DL.getABITypeAlignment(Ty);
----------------
With your changes, does this bit remain necessary?  I think this part is unsound anyway (since it relies on differentiating different pointer types of the same address space).


http://reviews.llvm.org/D12853