llvm-commits got removed from CC list when hitting reply-all to a Phab review

Duncan P. N. Exon Smith via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 15 17:13:21 PDT 2015


> On 2015-Sep-15, at 16:52, Manuel Klimek <klimek at google.com> wrote:
> 
> 
> 
> On Tue, Sep 15, 2015 at 4:33 PM Duncan P. N. Exon Smith <dexonsmith at apple.com> wrote:
> +llvm-commits
> 
> > On 2015-Sep-15, at 15:49, Teresa Johnson <tejohnson at google.com> wrote:
> >
> > I just realized that none of the discussion starting with Duncan's
> > review is going to llvm-commits, since llvm-commits is a subscriber in
> > Phab, but the review by email doesn't actually update Phab or cc the
> > subscribers (only the reviewers).
> 
> And I just added two more emails :(.
> 
> I'm not sure I understand how this happened.  Is it my fault somehow?  I just hit "reply-all" and I guess I didn't check the CC list.
> 
> If there was an email that was not cc'ed to llvm-commits, llvm-commits was not put in as subsriber before creating the revision (the creator of the revision has to make sure, just like if you manually send an email)
>  

This seems like a different case.  I've attached the original email as an attachment, but I'll quote the relevant part inline:

> Begin forwarded message:
> 
> From: Teresa Johnson <tejohnson at google.com>
> Date: 2015 September 1 at 10:53:51 PDT
> To: tejohnson at google.com, dexonsmith at apple.com, davidxl at google.com, mehdi.amini at apple.com
> Cc: llvm-commits at lists.llvm.org
> Subject: [PATCH] D12536: Function bitcode index in Value Symbol Table and lazy reading support
> Reply-To: reviews+D12536+public+4f470f0312a65d2b at reviews.llvm.org
> List-Id: reviews at reviews.llvm.org
> 
> tejohnson created this revision.
> tejohnson added reviewers: dexonsmith, davidxl, joker.eph.
> tejohnson added a subscriber: llvm-commits.
> 

Obviously I'm not a phab user, but it looks to me like this revision was created with llvm-commits as a subscriber.  Is there another way for llvm-commits to get dropped?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: [PATCH] D12536: Function bitcode index in Value Symbol Table and lazy reading support
Type: application/octet-stream
Size: 47731 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150915/55ad0e98/attachment.obj>


More information about the llvm-commits mailing list