[PATCH] D12709: [PATCH] [sanitizers] [msan] Enable MSAN for aarch64

Adhemerval Zanella via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 15 12:18:27 PDT 2015


zatrazz added a comment.

In http://reviews.llvm.org/D12709#246157, @rengolin wrote:

> One comment inline, another here:


Which macro do you mean ?

> Could you add a comment to the XFAILs stating very briefly what's wrong with it? I'd like to know what's an error you think you can fix it versus one that cannot be implemented due to hardware / architecture restrictions. Even if they all fall into temporary errors, would be good to know what exactly is breaking, to make it easier for people to pick them up and fix them, or even if some unrelated patch does fix them, they can know it's not unrelated after all.


Right, I will add comment about the failures reason (the ones I debugged at least).

> I guess about Darwin names, we shall see if it breaks the Darwin bots.

> 

> cheers,

> --renato





http://reviews.llvm.org/D12709





More information about the llvm-commits mailing list