[PATCH] D12836: [CorrelatedValuePropagation] Infer nonnull attributes

[Philip Reames via llvm-commits]

reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

LGTM w/minor comments addressed.


================
Comment at: test/Transforms/CorrelatedValuePropagation/non-null.ll:106
@@ +105,3 @@
+declare void @test10_helper(i8* %arg1, i8* %arg2, i32 %non-pointer-arg)
+define void @test10(i8* %arg1, i8* %arg2, i32 %non-pointer-arg) {
+entry:
----------------
Add CHECK-LABEL: @test10 please.

================
Comment at: test/Transforms/CorrelatedValuePropagation/non-null.ll:116
@@ +115,3 @@
+
+null:
+  call void @test10_helper(i8* %arg1, i8* %arg2, i32 %non-pointer-arg)
----------------
Adding a test case which shows a merge point with two known nonnull pointers merging through a phi into a call would nicely illustrate the power of this transformation.  Do you mind adding that?


Repository:
  rL LLVM

http://reviews.llvm.org/D12836