[PATCH] D12837: [Polly] Revise polly-{update|check}-format targets

Michael Kruse via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 14 10:40:03 PDT 2015


Meinersbur added a comment.

In http://reviews.llvm.org/D12837#245328, @jdoerfert wrote:

> > Meinersbur added a comment.
>
> > 
>
> > In http://reviews.llvm.org/D12837#245090, @grosser wrote:
>
> > 
>
> > > Looking at this, it would also be great if we would call polly-check-format from check-polly, if clang-format is available in our build (and we are not just a LLVM+Polly build).
>
> > 
>
> > In another commit.
>
> > 
>
> > I personally think this would be exaggerated.  Some white space in the source has no influence on the correctness of build product. Also, LLVM doesn't do this either.
>
>
> As long as we break the buildbots with white space errors it makes sense
>  to break the local unit tests too. I would like such a feature if
>  possible.


You can just run "ninja check-polly polly-check-format".

However, here is the patch: http://reviews.llvm.org/D12850


Repository:
  rL LLVM

http://reviews.llvm.org/D12837





More information about the llvm-commits mailing list