[PATCH] D12837: [Polly] Revise polly-{update|check}-format targets

Tobias Grosser via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 14 06:49:55 PDT 2015


LGTM.

Looking at this, it would also be great if we would call polly-check-format from check-polly, if clang-format is available in our build (and we are not just a LLVM+Polly build).

Best,
Tobias

On 09/14/2015 03:44 PM, Michael Kruse wrote:
> Meinersbur created this revision.
> Meinersbur added reviewers: jdoerfert, grosser.
> Meinersbur added subscribers: llvm-commits, pollydev.
> Meinersbur added a project: Polly.
>
> Make clang-format run on each file independently using add_custom_format (instead using a shell script in utils/). The targets polly-{update|check}-format depend on these.
>
> The primary motivation is to make them work on Windows, but also improves them generally:
> - Each file update/check can run in parallel (Although they do not take long to run anyway)
> - Implicit dependency on clang-format, so it recompiles if necessary
> - polly-check-format shows the formatting difference if failing
>
> http://reviews.llvm.org/D12837
>
> Files:
>    CMakeLists.txt
>    utils/check_format.sh
>    utils/update_format.sh
>



More information about the llvm-commits mailing list