[PATCH] D12557: [AtomicExpand] Refactor load/cmpxchg callbacks to make LLSC explicit. NFCI.

[NAKAMURA Takumi via llvm-commits]

chapuni added a subscriber: chapuni.
chapuni added a comment.

This causes crash.

See, http://bb.pgr.jp/builders/msbuild-llvmclang-x64-msc18-DA/builds/562
http://bb.pgr.jp/builders/msbuild-llvmclang-x64-msc18-DA/builds/562/steps/test-llvm/logs/LLVM%20%3A%3A%20CodeGen__X86__atomic_idempotent.ll

(I reproduced with valgrind, too)


================
Comment at: llvm/trunk/lib/CodeGen/AtomicExpandPass.cpp:509
@@ -511,1 +508,3 @@
+  if (auto ResultingLoad = TLI->lowerIdempotentRMWIntoFencedLoad(RMWI))
+    return tryExpandAtomicLoad(ResultingLoad);
   return false;
----------------
If ResultingLoad is not null but tryExpandAtomicLoad(ResultingLoad) failed, This method returns true in despite of invalidated RMWI.


Repository:
  rL LLVM

http://reviews.llvm.org/D12557