[PATCH] D12773: [PM] Port SROA to the new pass manager.

Chandler Carruth via llvm-commits llvm-commits at lists.llvm.org
Sat Sep 12 02:08:54 PDT 2015

Thanks Justin, and thanks to the others for all the useful comments.
Landing this, and will switch to post-commit review for the subsequent pass
porting as long as its boring and mechanically following this pattern.
Naturally, I'll surface anything interesting and get feedback first. Shout
if folks see issues or if they start disliking the patterns here.

On Fri, Sep 11, 2015 at 10:24 PM Justin Bogner via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Chandler Carruth <chandlerc at gmail.com> writes:
> > Thanks for the feeback!
> >
> > On Fri, Sep 11, 2015 at 11:47 AM Justin Bogner via llvm-commits <
> > llvm-commits at lists.llvm.org> wrote:
> >
> >     A couple of minor comments below, then as long as nobody's opposed to
> >     this path it LGTM.
> >
> > Comments addressed, but there is one outstanding question I'd like a
> better
> > answer to before I move forward: how to name the legacy pass manager
> passes.
> >
> > I don't actually have strong feelings here. Here is the current
> reasoning I
> > see, which doesn't leave a clear choice IMO:
> >
> > - FooWrapperPass is a legacy PM wrapper around the Foo analysis results
> > - FooLegacyPass is a legacy PM pass for the Foo transformation
> >
> > Meh. Thoughts?
> Yeah, I don't have strong feelings either. As long as there's some
> distinction between the Legacy vs Wrapper naming and it isn't just "toss
> a coin and choose a name" I'm fine with using both. It'd also be fine to
> standardize on "Legacy", IMO.
> This is good to go in. It's pretty much the best of the solutions that
> have been brought up so far, nobody's really objected, and if someone
> comes up with something better we can always change it.
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150912/1c32129e/attachment.html>

More information about the llvm-commits mailing list