[PATCH] D12790: ubsan: Implement memory permission validation for vtables.

Peter Collingbourne via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 11 15:21:24 PDT 2015


pcc added inline comments.

================
Comment at: lib/ubsan/ubsan_type_hash_itanium.cc:197
@@ +196,3 @@
+#if SANITIZER_LINUX
+bool isValidVptr(void *Vtable) {
+  // Validate the memory permissions of the vtable pointer and the first
----------------
samsonov wrote:
> These two functions should be static
They are both in an anonymous namespace, so they don't need to be.


Repository:
  rL LLVM

http://reviews.llvm.org/D12790





More information about the llvm-commits mailing list