[PATCH] D12248: Put profile variables of COMDAT functions to it's own COMDAT group

Diego Novillo via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 11 07:17:32 PDT 2015


dnovillo added a comment.

With David's suggestions and a test case, this LGTM.


================
Comment at: InstrProfiling.cpp:199
@@ -198,4 +198,3 @@
 
-  // Move the name variable to the right section. Make sure it is placed in the
-  // same comdat as its associated function. Otherwise, we may get multiple
-  // counters for the same function in certain cases.
+  // Move the name variable to the right section. Make them in a COMDAT group
+  // if the associated function is a COMDAT. This will make sure that
----------------
s/Make/Place/


http://reviews.llvm.org/D12248





More information about the llvm-commits mailing list