[PATCH] D12763: [PATCH] [compiler-rt] [sanitizers] Add VMA size check at runtime

Dmitry Vyukov via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 11 00:54:49 PDT 2015


dvyukov added a comment.

Otherwise LGTM


================
Comment at: lib/sanitizer_common/sanitizer_posix.cc:335
@@ +334,3 @@
+  if (kBuiltVMA != maxRuntimeVMA) {
+    Printf("WARNING: Runtime VMA is not the one built for.\n");
+    Printf("\tBuilt VMA:   %u bits\n", kBuiltVMA);
----------------
Add tool name in the beginning. There is a function SanitizerToolName() or something like that.
We generally prefix all output with tool name, because sometimes people run third_party programs or very large programs, and they may not know that this output comes from the tool.


http://reviews.llvm.org/D12763





More information about the llvm-commits mailing list