[PATCH] D12745: [IndVars] Widen more comparisons for non-negative induction vars.

Philip Reames via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 10 14:46:19 PDT 2015

reames added inline comments.

Comment at: test/Transforms/IndVarSimplify/widen-loop-comp.ll:213
@@ +212,3 @@
+  %idxprom = zext i32 %i.0 to i64
+  %arrayidx = getelementptr inbounds i32, i32* %a, i64 %idxprom
I would prefer you left them.  The zero based increasing loop is a simpler, easier to understand, and really important case.  I think there's value even if they're covered by the additional cases.  


More information about the llvm-commits mailing list