[PATCH] D12772: [InstCombineCalls] Use isKnownNonNullAt() to check nullness of gc.relocate return value

Philip Reames via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 10 14:42:58 PDT 2015

reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

LGTM w/minor comment addressed.

Comment at: test/Transforms/InstCombine/gc.relocate.ll:26
@@ +25,3 @@
+; CHECK-LABEL: @explicit_nonnull
+; CHECK: call nonnull
I'd replace this vague check line with a bit of IR that will constant fold if the pointer is known non null.  e.g. return (relocate == null);
; CHECK: ret i1 false


More information about the llvm-commits mailing list