[PATCH] D12723: llvm-mc-fuzzer: A fuzzing tool for the MC layer.

[Kostya Serebryany via llvm-commits]

kcc added inline comments.

================
Comment at: docs/LibFuzzer.rst:432
@@ -431,2 +431,3 @@
 
-
+  * Disassembler: Discovered a class of bug in the Mips disassembler where
+    instructions would successfully disassemble in ISA's that lack the
----------------
Links maybe? 

================
Comment at: tools/llvm-mc-fuzzer/llvm-mc-fuzzer.cpp:98
@@ +97,3 @@
+  // If your aim is to find instructions that are not tested, then it is
+  // advisable to contrain the maximum input size to a single instruction
+  // using -max_len as in the first example. This results in a test corpus of
----------------
typeo: contrain

================
Comment at: tools/llvm-mc-fuzzer/llvm-mc-fuzzer.cpp:104
@@ +103,3 @@
+  LLVMInitializeAllTargetInfos();
+  LLVMInitializeAllTargetMCs();
+  LLVMInitializeAllDisassemblers();
----------------
I've just added more interface variants: 
Can you try this one? 

int FuzzerDriver(const std::vector<std::string> &Args, UserCallback Callback);

================
Comment at: tools/llvm-mc-fuzzer/llvm-mc-fuzzer.cpp:110
@@ +109,3 @@
+  // Package up features to be passed to target/subtarget
+  // We have to pass it via a global since the callback doesn't
+  // permit any user data.
----------------
Ok, makes sense 


http://reviews.llvm.org/D12723