[PATCH] D12660: Make the default triple optional by allowing an empty string
Mehdi AMINI via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 9 22:14:51 PDT 2015
joker.eph added a comment.
In http://reviews.llvm.org/D12660#243011, @joker.eph wrote:
> In http://reviews.llvm.org/D12660#242029, @probinson wrote:
> > Does llvm-mc always need a triple? That is, would it be better to add test/tools/llvm-mc/lit.local.cfg (like you did for test/DebugInfo) instead of adding REQUIRES to each test/tools/llvm-mc/* file?
> Created test/tools/llvm-mc/Generic/
I submitted unintentionally. I added a lit.local.cfg.
> > It seems weird for target-specific tests to require a default triple, but I guess those are the kinds of tests where you and jyknight are talking about iterating over some list of triples, and that seems like a good future direction.
> Do you mean the ones in test/CodeGen/PowerPC, test/CodeGen/X86, etc.?
> They really either shouldn't be in these directory, or should specify a triple. This is a bit messy but I wasn't sure which triple to define for these.
> > Have you thought about moving test/DebugInfo/*.ll to a Generic subdirectory? Not saying you should or should not, but it seems possibly sub-optimal to require a default triple for *all* DebugInfo tests, even the target-specific ones. But maybe it's okay the way it is; I haven't done any particular research or thought about it much.
Moved as suggested.
Thanks for the comments!
More information about the llvm-commits