[PATCH] D12153: Support inline functions symbolization in Addr2Line symbolizer.

[Alexey Samsonov via llvm-commits]

samsonov added a comment.

Yes, IMO it looks better. Only a few minor comments.


================
Comment at: lib/sanitizer_common/sanitizer_symbolizer_posix_libcdep.cc:209
@@ +208,3 @@
+  bool ReadFromSymbolizer(char *buffer, uptr max_length) override {
+    bool result = SymbolizerProcess::ReadFromSymbolizer(buffer, max_length);
+    // We should cut out output_terminator_ at the end of given buffer,
----------------
You shouldn't really do anything if ReadFromSymbolizer fails.

  if (!ReadFromSymbolizer())
    return false;
  //...
  return true;

================
Comment at: lib/sanitizer_common/sanitizer_symbolizer_posix_libcdep.cc:216
@@ +215,3 @@
+
+  void TrimOutputBuffer(char *buffer, uptr read_len) {
+    // We cannot scan buffer from it's beginning, because it is legal for it
----------------
You probably don't need a dedicated function for this now.

================
Comment at: lib/sanitizer_common/sanitizer_symbolizer_posix_libcdep.cc:218
@@ +217,3 @@
+    // We cannot scan buffer from it's beginning, because it is legal for it
+    // to start with output_terminator_ in case of given offset is invalid. So,
+    // scanning from second character.
----------------
"in case given offset is invalid"


http://reviews.llvm.org/D12153